Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/110167

Change subject: Display error message if browser is not started for some reason
......................................................................

Display error message if browser is not started for some reason

Change-Id: I486c056c8302a112f384bcd1d7a9611f9d463cd7
---
M lib/mediawiki/selenium/sauce.rb
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium 
refs/changes/67/110167/1

diff --git a/lib/mediawiki/selenium/sauce.rb b/lib/mediawiki/selenium/sauce.rb
index 7d0cedb..ee94d13 100644
--- a/lib/mediawiki/selenium/sauce.rb
+++ b/lib/mediawiki/selenium/sauce.rb
@@ -14,7 +14,11 @@
 module Cucumber::Formatter
   class Sauce < Junit
     def format_exception(exception)
-      sauce_job_page = "Sauce Labs job URL: 
http://saucelabs.com/jobs/#{$session_id}\n";
+      if $session_id
+        sauce_job_page = "Sauce Labs job URL: 
http://saucelabs.com/jobs/#{$session_id}\n";
+      else
+        sauce_job_page = "Uh-oh. Could not find link to Sauce Labs job URL."
+      end
       ([sauce_job_page] + ["#{exception.message} (#{exception.class})"] + 
exception.backtrace).join("\n")
     end
   end

-- 
To view, visit https://gerrit.wikimedia.org/r/110167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I486c056c8302a112f384bcd1d7a9611f9d463cd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to