Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/110597
Change subject: Fix browser tests for new topic UI
......................................................................
Fix browser tests for new topic UI
Edit post is no longer in a flyout.
Bug: 60673
Change-Id: I35d1435aa956b545c20f51d2ff44ed44e5ba834d
---
M tests/browser/features/edit_existing.feature
M tests/browser/features/step_definitions/edit_existing_steps.rb
M tests/browser/features/support/pages/flow_page.rb
3 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/97/110597/1
diff --git a/tests/browser/features/edit_existing.feature
b/tests/browser/features/edit_existing.feature
index e43819e..c2264ff 100644
--- a/tests/browser/features/edit_existing.feature
+++ b/tests/browser/features/edit_existing.feature
@@ -16,7 +16,7 @@
Scenario: Edit existing post
Given I am on Flow page
- When I click the Edit post pencil icon
+ When I click Edit post
Then I should be able to edit the post field with Post edited
And I should be able to save the new post
And the saved post should contain Post edited
diff --git a/tests/browser/features/step_definitions/edit_existing_steps.rb
b/tests/browser/features/step_definitions/edit_existing_steps.rb
index 21f5de7..fd626f1 100644
--- a/tests/browser/features/step_definitions/edit_existing_steps.rb
+++ b/tests/browser/features/step_definitions/edit_existing_steps.rb
@@ -1,12 +1,12 @@
-When(/^I click the Edit post pencil icon$/) do
+When(/^I click Edit post$/) do
on(FlowPage) do |page|
- page.topic_post_element.when_present.hover
- page.edit_post_icon_element.when_present.click
+ page.edit_post_element.when_present.click
end
end
When(/^I click the Edit title pencil icon$/) do
on(FlowPage) do |page|
+ # TODO (bug 60673) have to open the topic's action menu to see this.
page.topic_title_element.when_present.hover
page.edit_title_icon_element.when_present.click
end
diff --git a/tests/browser/features/support/pages/flow_page.rb
b/tests/browser/features/support/pages/flow_page.rb
index b3c95e4..c7915d7 100644
--- a/tests/browser/features/support/pages/flow_page.rb
+++ b/tests/browser/features/support/pages/flow_page.rb
@@ -20,7 +20,7 @@
button(:change_post_save, class: "flow-edit-post-submit")
button(:change_title_save, class: "flow-edit-title-submit")
a(:contrib_link, text: "contribs")
- a(:edit_post_icon, title: "Edit post", index: topic_index)
+ a(:edit_post, class: "flow-edit-post-link", index: topic_index)
a(:edit_title_icon, title: "Edit title", index: topic_index)
div(:flow_body, class: "flow-container")
list_item(:full_view, title: "Full view")
--
To view, visit https://gerrit.wikimedia.org/r/110597
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35d1435aa956b545c20f51d2ff44ed44e5ba834d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
