Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/110684
Change subject: Conditionally load jquery.jStorage module
......................................................................
Conditionally load jquery.jStorage module
Load it only for anonymous users.
Introduce 'ext.uls.anon.preferences' RL module for this.
Need to top load this module because this is a conditional dependency
to another top loaded module 'ext.uls.interface'. This get loaded
if the user is anonymous.
Change-Id: I22613d9f6846db5456beb532cec47396fccda8ae
---
M Resources.php
M UniversalLanguageSelector.hooks.php
2 files changed, 15 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/84/110684/1
diff --git a/Resources.php b/Resources.php
index 80400c3..dded1cc 100644
--- a/Resources.php
+++ b/Resources.php
@@ -140,8 +140,19 @@
'dependencies' => array(
'mediawiki.user',
'mediawiki.api',
+ ),
+) + $resourcePaths;
+
+$wgResourceModules['ext.uls.anon.preferences'] = array(
+ 'dependencies' => array(
+ 'ext.uls.preferences',
'jquery.jStorage',
),
+ // Need to top load this because this is a conditional dependency
+ // to another top loaded module ext.uls.interface. This get loaded
+ // if the user is anonymous.
+ // See addModules method of UniversalLanguageSelector.hooks.php
+ 'position' => 'top',
) + $resourcePaths;
$wgResourceModules['ext.uls.webfonts'] = array(
diff --git a/UniversalLanguageSelector.hooks.php
b/UniversalLanguageSelector.hooks.php
index 9315718..2affea5 100644
--- a/UniversalLanguageSelector.hooks.php
+++ b/UniversalLanguageSelector.hooks.php
@@ -77,6 +77,10 @@
$out->addModules( 'ext.uls.interlanguage' );
}
+ if ( $out->getUser()->isAnon() ) {
+ $out->addModules( 'ext.uls.anon.preferences' );
+ }
+
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/110684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22613d9f6846db5456beb532cec47396fccda8ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
