Imjacobclark has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/110693

Change subject: Added wfSuppressWarnings and wfRestoreWarnings before and after 
the ini_set call to apc cache by default to suppress errors if ini_set is 
disabled
......................................................................

Added wfSuppressWarnings and wfRestoreWarnings before and after the ini_set 
call to apc cache by default to suppress errors if ini_set is disabled

Change-Id: If91e99c30fce3af14e69acd35112af188e62b6ac
---
M includes/cache/LocalisationCache.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/93/110693/1

diff --git a/includes/cache/LocalisationCache.php 
b/includes/cache/LocalisationCache.php
index cba2ba7..c1063f5 100644
--- a/includes/cache/LocalisationCache.php
+++ b/includes/cache/LocalisationCache.php
@@ -512,8 +512,11 @@
                // Disable APC caching
                $_apcEnabled = ini_set( 'apc.cache_by_default', '0' );
                include $_fileName;
-               ini_set( 'apc.cache_by_default', $_apcEnabled );
 
+               wfSuppressWarnings()
+                       ini_set( 'apc.cache_by_default', $_apcEnabled );
+               wfRestoreWarnings()
+               
                if ( $_fileType == 'core' || $_fileType == 'extension' ) {
                        $data = compact( self::$allKeys );
                } elseif ( $_fileType == 'aliases' ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/110693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If91e99c30fce3af14e69acd35112af188e62b6ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Imjacobclark <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to