Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/110894
Change subject: Fix API QUnit tests that are not aware of wgDebugToolbar
......................................................................
Fix API QUnit tests that are not aware of wgDebugToolbar
Some QUnit tests were breaking because they assumed you could get [] back from
the API even when $wgDebugToolbar was true
Change-Id: I58add90738becbd6caac217a0be32c465a904e36
---
M tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/94/110894/1
diff --git a/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js
b/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js
index 9eda75c..6e9cfe4 100644
--- a/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js
+++ b/tests/qunit/suites/resources/mediawiki.api/mediawiki.api.test.js
@@ -9,7 +9,12 @@
d1 = api.get( {} )
.done( function ( data ) {
- assert.deepEqual( data, [], 'If request
succeeds without errors, resolve deferred' );
+ if ( !( data instanceof Array ) ) {
+ delete data.debuginfo;
+ assert.deepEqual( data, {}, 'If request
succeeds without errors, resolve deferred' );
+ } else {
+ assert.deepEqual( data, [], 'If request
succeeds without errors, resolve deferred' );
+ }
} );
d2 = api.get( {
@@ -21,7 +26,12 @@
d3 = api.post( {} )
.done( function ( data ) {
- assert.deepEqual( data, [], 'Simple POST
request' );
+ if ( !( data instanceof Array ) ) {
+ delete data.debuginfo;
+ assert.deepEqual( data, {}, 'Simple
POST request' );
+ } else {
+ assert.deepEqual( data, [], 'Simple
POST request' );
+ }
} );
// After all are completed, continue the test suite.
--
To view, visit https://gerrit.wikimedia.org/r/110894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58add90738becbd6caac217a0be32c465a904e36
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
