Adamw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/110905

Change subject: Overlooked a nonexistent variable reference
......................................................................

Overlooked a nonexistent variable reference

Followup to Iafc6fcaec8aadeb81edc1fd3a4b815f4f2acb232

Change-Id: I2157369cbbb5fa80614c900082eed9a0c779730a
---
M sites/all/modules/wmf_common/Queue.php
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/05/110905/1

diff --git a/sites/all/modules/wmf_common/Queue.php 
b/sites/all/modules/wmf_common/Queue.php
index 2741008..21b9c27 100644
--- a/sites/all/modules/wmf_common/Queue.php
+++ b/sites/all/modules/wmf_common/Queue.php
@@ -174,12 +174,10 @@
         }
         catch ( Exception $ex ) {
             watchdog( 'wmf_common', "Aborting DB transaction.", NULL, 
WATCHDOG_INFO );
-            if ( $transactional ) {
-                $native_civi_transaction->rollback();
-                $crm_transaction->rollback();
-                $ct_transaction->rollback();
-                $drupal_transaction->rollback();
-            }
+            $native_civi_transaction->rollback();
+            $crm_transaction->rollback();
+            $ct_transaction->rollback();
+            $drupal_transaction->rollback();
 
             throw $ex;
         }

-- 
To view, visit https://gerrit.wikimedia.org/r/110905
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2157369cbbb5fa80614c900082eed9a0c779730a
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to