Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/110929
Change subject: Add es3 to catch use of 'new' as object key.
......................................................................
Add es3 to catch use of 'new' as object key.
This would have caught the IE8 breakage of
mw.flow.action.topic.new();
that was fixed in 7c7b7c21a.
Change-Id: I6e7ab8de037fb23460fdb13b7bdc83dda093a9ae
---
M .jshintrc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/29/110929/1
diff --git a/.jshintrc b/.jshintrc
index 20762bc..d495cd7 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -17,6 +17,7 @@
"curly": true, // requres curly braces around loops and conditionals
"devel": true, // console, alert, etc.
"eqeqeq": true, // prohibits == and !=
+ "es3": true, // catch foo.new object keys
"forin": false, // make for-in loops require hasOwnProperty check
"onevar": true, // only one var declaration per function
"supernew": true, // suppress warnings about "weird" object
constructions
--
To view, visit https://gerrit.wikimedia.org/r/110929
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e7ab8de037fb23460fdb13b7bdc83dda093a9ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
