jenkins-bot has submitted this change and it was merged.
Change subject: Use mediawiki.ui.button when mw-ui-button is used
......................................................................
Use mediawiki.ui.button when mw-ui-button is used
* 9e4e58bce8d10f65cf298b39f48e86c41b6a82b8 broke this into a separate
module (for modularity, and potentially to allow wiki content to use
mw.ui buttons by default in the future).
* Currently, the button code is in both mediawiki.ui and
mediawiki.ui.button for backwards compatibility. However, it will be
removed from mediawiki.ui when existing uses transition over.
* SpecialMWOAuth.php is using mw.ui buttons and other mw.ui features
* SpecialMWOAuthManageMyGrants.php is only using buttons.
Change-Id: I52ccf49464c714ab5fb8944fb46b5b8fbdc5fc55
---
M frontend/specialpages/SpecialMWOAuth.php
M frontend/specialpages/SpecialMWOAuthManageMyGrants.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
CSteipp: Looks good to me, approved
jenkins-bot: Verified
diff --git a/frontend/specialpages/SpecialMWOAuth.php
b/frontend/specialpages/SpecialMWOAuth.php
index 8b86738..35fc82d 100644
--- a/frontend/specialpages/SpecialMWOAuth.php
+++ b/frontend/specialpages/SpecialMWOAuth.php
@@ -274,7 +274,7 @@
);
}
- $this->getOutput()->addModuleStyles( array( 'mediawiki.ui',
'ext.MWOAuth.AuthorizeForm' ) );
+ $this->getOutput()->addModuleStyles( array( 'mediawiki.ui',
'mediawiki.ui.button', 'ext.MWOAuth.AuthorizeForm' ) );
$this->getOutput()->addModules( 'ext.MWOAuth.AuthorizeDialog' );
// Check if this user has authorized grants for this consumer
previously
diff --git a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
index d195b7e..9f563fd 100644
--- a/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
+++ b/frontend/specialpages/SpecialMWOAuthManageMyGrants.php
@@ -124,7 +124,7 @@
throw new PermissionsError( 'mwoauthviewsuppressed' );
}
- $this->getOutput()->addModuleStyles( 'mediawiki.ui' );
+ $this->getOutput()->addModuleStyles( 'mediawiki.ui.button' );
$action = '';
if ( $this->getRequest()->getCheck( 'renounce' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/111326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52ccf49464c714ab5fb8944fb46b5b8fbdc5fc55
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
