jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Distinguish between wikitext and VE editor in browser
tests
......................................................................
Hygiene: Distinguish between wikitext and VE editor in browser tests
Make this clearer.
Change-Id: If4fb788d0d3a305bd8936e1d00841a988a57c7b1
---
M tests/browser/features/step_definitions/editor_steps.rb
R tests/browser/features/wikitext_editor.feature
2 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
Awjrichards: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/editor_steps.rb
b/tests/browser/features/step_definitions/editor_steps.rb
index d8096fd..eb7ffb2 100644
--- a/tests/browser/features/step_definitions/editor_steps.rb
+++ b/tests/browser/features/step_definitions/editor_steps.rb
@@ -6,14 +6,14 @@
on(ArticlePage).edit_link_element.when_present.click
end
-Then(/^I see the editor$/) do
+Then(/^I see the wikitext editor$/) do
on(ArticlePage).editor_overlay_element.should be_visible
end
-When(/^I click the editor overlay close button$/) do
+When(/^I click the wikitext editor overlay close button$/) do
on(ArticlePage).editor_overlay_close_button_element.click
end
-Then(/^I should not see the editor$/) do
+Then(/^I should not see the wikitext editor$/) do
on(ArticlePage).editor_overlay_element.should_not be_visible
end
diff --git a/tests/browser/features/editor.feature
b/tests/browser/features/wikitext_editor.feature
similarity index 73%
rename from tests/browser/features/editor.feature
rename to tests/browser/features/wikitext_editor.feature
index 02f1320..933d40a 100644
--- a/tests/browser/features/editor.feature
+++ b/tests/browser/features/wikitext_editor.feature
@@ -1,5 +1,5 @@
@en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org
-Feature: Editor
+Feature: Wikitext Editor
Background:
Given I am logged into the mobile website
@@ -7,14 +7,14 @@
And I click the edit button
Scenario: Opening editor
- Then I see the editor
+ Then I see the wikitext editor
Scenario: Closing editor (overlay button)
- When I click the editor overlay close button
- Then I should not see the editor
+ When I click the wikitext editor overlay close button
+ Then I should not see the wikitext editor
And the URL of of my page should contain Nonexistent_page_ijewrcmhvg34773
Scenario: Closing editor (browser button)
When I click the browser back button
- Then I should not see the editor
+ Then I should not see the wikitext editor
And the URL of of my page should contain Nonexistent_page_ijewrcmhvg34773
--
To view, visit https://gerrit.wikimedia.org/r/111241
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4fb788d0d3a305bd8936e1d00841a988a57c7b1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
