Trevor Parscal has submitted this change and it was merged. Change subject: Optimize UI tool state updates. ......................................................................
Optimize UI tool state updates. Rather than each tool requesting annotations, and nodes pertaining to selection, Emitted event supplies annotations and nodes to each tool's update method. Using select vs. of traverseLeafNodes for code optimization. Better documentation for updateTools() Removed unneeded code. Change-Id: I7c0baa1cc0f7fb731d6e28b175a76e931e9e2961 --- M modules/ve/test/ve.BranchNode.test.js M modules/ve/ui/tools/ve.ui.AnnotationButtonTool.js M modules/ve/ui/tools/ve.ui.ClearButtonTool.js M modules/ve/ui/tools/ve.ui.FormatDropdownTool.js M modules/ve/ui/tools/ve.ui.HistoryButtonTool.js M modules/ve/ui/tools/ve.ui.IndentationButtonTool.js M modules/ve/ui/tools/ve.ui.ListButtonTool.js M modules/ve/ui/ve.ui.Tool.js M modules/ve/ui/ve.ui.Toolbar.js M modules/ve/ve.BranchNode.js 10 files changed, 47 insertions(+), 321 deletions(-) Approvals: Robmoen: Looks good to me, but someone else must approve Trevor Parscal: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/24240 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c0baa1cc0f7fb731d6e28b175a76e931e9e2961 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Robmoen <rm...@wikimedia.org> Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org> Gerrit-Reviewer: Robmoen <rm...@wikimedia.org> Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
