Ottomata has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/111812

Change subject: Parameterizing num.replica.fetchers and replica.fetch.max.bytes
......................................................................

Parameterizing num.replica.fetchers and replica.fetch.max.bytes

Change-Id: I1e8726a094fb930c8fc2b04687c24bb703d013c7
---
M manifests/defaults.pp
M manifests/server.pp
M templates/server.properties.erb
3 files changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/kafka 
refs/changes/12/111812/1

diff --git a/manifests/defaults.pp b/manifests/defaults.pp
index 7dafcc5..17e2193 100644
--- a/manifests/defaults.pp
+++ b/manifests/defaults.pp
@@ -31,6 +31,8 @@
     $nofiles_ulimit                  = 8192
 
     $auto_create_topics_enable       = false
+    $num_replica_fetchers            = 1
+    $replica_fetch_max_bytes         = 1048576
 
     $num_network_threads             = 2
     $num_io_threads                  = 2
diff --git a/manifests/server.pp b/manifests/server.pp
index 9d15246..d55591e 100644
--- a/manifests/server.pp
+++ b/manifests/server.pp
@@ -39,6 +39,13 @@
 #
 # $auto_create_topics_enable        - If autocreation of topics is allowed.  
Default: false
 #
+# $num_replica_fetchers             - Number of threads used to replicate 
messages from leaders.
+#                                     Default: 1
+#
+# $replica_fetch_max_bytes          - The number of bytes of messages to 
attempt to fetch for each
+#                                     partition in the fetch requests the 
replicas send to the leader.
+#                                     Default: 1024 * 1024
+#
 # $num_network_threads              - The number of threads handling network
 #                                     requests.  Default: 2
 #
@@ -99,6 +106,8 @@
     $nofiles_ulimit                  = $kafka::defaults::nofiles_ulimit,
 
     $auto_create_topics_enable       = 
$kafka::defaults::auto_create_topics_enable,
+    $num_replica_fetchers            = $kafka::defaults::num_replica_fetchers,
+    $replica_fetch_max_bytes         = 
$kafka::defaults::replica_fetch_max_bytes,
 
     $num_network_threads             = $kafka::defaults::num_network_threads,
     $num_io_threads                  = $kafka::defaults::num_io_threads,
diff --git a/templates/server.properties.erb b/templates/server.properties.erb
index 3443677..0e5618f 100644
--- a/templates/server.properties.erb
+++ b/templates/server.properties.erb
@@ -56,6 +56,16 @@
 # and number of partitions.
 auto.create.topics.enable=<%= @auto_create_topics_enable ? 'true' : 'false' %>
 
+# Number of threads used to replicate messages from leaders. Increasing this
+# value can increase the degree of I/O parallelism in the follower broker.
+# This is useful to temporarily increase if you have a broker that needs
+# to catch up on messages to get back into the ISR.
+num.replica.fetchers=<%= @num_replica_fetchers %>
+
+# The number of byes of messages to attempt to fetch for each partition in the
+# fetch requests the replicas send to the leader.
+replica.fetch.max.bytes=<%= @replica_fetch_max_bytes %>
+
 ############################# Log Flush Policy #############################
 
 # The following configurations control the flush of data to disk. This is the 
most

-- 
To view, visit https://gerrit.wikimedia.org/r/111812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e8726a094fb930c8fc2b04687c24bb703d013c7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/kafka
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to