Phuedx has submitted this change and it was merged.
Change subject: Use mediawiki.ui.button instead of mediawiki.ui
......................................................................
Use mediawiki.ui.button instead of mediawiki.ui
* 9e4e58bce8d10f65cf298b39f48e86c41b6a82b8 separated mediawiki.ui.button
into a separate module (for modularity, and potentially to allow
wiki content to use mw.ui buttons by default in the future).
* Currently, the button code is in both mediawiki.ui and
mediawiki.ui.button for backwards compatibility. However, it will be
removed from mediawiki.ui when existing uses transition over.
* Only the button features of mw.ui are used here.
* Add comment to explain why addModuleStyles is not used.
Change-Id: I047e3bf6f7f2121f6be87a041c776e6771a697f0
---
M GuidedTour.php
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/GuidedTour.php b/GuidedTour.php
index 7b3a075..8c4af8f 100644
--- a/GuidedTour.php
+++ b/GuidedTour.php
@@ -76,7 +76,10 @@
'remoteExtPath' => 'GuidedTour/modules',
'dependencies' => array(
'mediawiki.libs.guiders',
- 'mediawiki.ui',
+ // Ideally 'mediawiki.ui.button' should be added with
addModuleStyles to
+ // avoid duplication.
+ // However, that wouldn't work if a tour is loaded dynamically
on the client-side.
+ 'mediawiki.ui.button',
),
);
--
To view, visit https://gerrit.wikimedia.org/r/111356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I047e3bf6f7f2121f6be87a041c776e6771a697f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GuidedTour
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
