Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/112045
Change subject: Add notification in login screen if there is no network
......................................................................
Add notification in login screen if there is no network
Change-Id: I30ba9a1ecd0dc23726f145b7d14c69d3a034436e
---
M wikipedia/res/values/strings.xml
M wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/45/112045/1
diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml
index ab89bf1..78b0777 100644
--- a/wikipedia/res/values/strings.xml
+++ b/wikipedia/res/values/strings.xml
@@ -76,4 +76,5 @@
<string name="login_error_throttled">
<![CDATA[Too many login attempts. Wait for a few minutes & try
again?]]></string>
<string name="login_error_unknown">Login failed :(</string>
+ <string name="login_error_no_network">No network connection</string>
</resources>
diff --git a/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
b/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
index 1c278d2..0ba18a0 100644
--- a/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
@@ -93,6 +93,13 @@
}
@Override
+ public void onCatch(Throwable caught) {
+ Log.d("Wikipedia", "Caught " + caught.toString());
+ progressDialog.dismiss();
+ Crouton.makeText(LoginActivity.this,
R.string.login_error_no_network, Style.ALERT).show();
+ }
+
+ @Override
public void onFinish(String result) {
progressDialog.dismiss();
if (result.equals("Success")) {
--
To view, visit https://gerrit.wikimedia.org/r/112045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30ba9a1ecd0dc23726f145b7d14c69d3a034436e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
