Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/113776
Change subject: Using @custom-browser Cucumber tag instead of @user_agent ...................................................................... Using @custom-browser Cucumber tag instead of @user_agent Implementing the convention: https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#Option al_tags Bug: 61458 Change-Id: Iae1e40e04c0b993a45c1e46cd971c183b483bc70 --- M tests/browser/Gemfile.lock M tests/browser/features/login_required_watchlist.feature M tests/browser/features/random_ua.feature M tests/browser/features/support/hooks.rb 4 files changed, 16 insertions(+), 19 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/76/113776/1 diff --git a/tests/browser/Gemfile.lock b/tests/browser/Gemfile.lock index a51676e..e5cbbff 100644 --- a/tests/browser/Gemfile.lock +++ b/tests/browser/Gemfile.lock @@ -2,9 +2,9 @@ remote: https://rubygems.org/ specs: builder (3.2.2) - childprocess (0.4.0) + childprocess (0.5.0) ffi (~> 1.0, >= 1.0.11) - chunky_png (1.2.9) + chunky_png (1.3.0) cucumber (1.3.10) builder (>= 2.1.2) diff-lcs (>= 1.1.3) @@ -23,19 +23,19 @@ headless (1.0.1) i18n (0.6.9) json (1.8.1) - mediawiki_selenium (0.2.0) - cucumber (~> 1.3.10) - headless (~> 1.0.1) - json (~> 1.8.1) - net-http-persistent (~> 2.9.1) - page-object (~> 0.9.5) - rest-client (~> 1.6.7) - rspec-expectations (~> 2.14.4) - syntax (~> 1.2.0) + mediawiki_selenium (0.2.4) + cucumber (~> 1.3, >= 1.3.10) + headless (~> 1.0, >= 1.0.1) + json (~> 1.8, >= 1.8.1) + net-http-persistent (~> 2.9, >= 2.9.1) + page-object (~> 0.9, >= 0.9.5) + rest-client (~> 1.6, >= 1.6.7) + rspec-expectations (~> 2.14, >= 2.14.4) + syntax (~> 1.2, >= 1.2.0) mime-types (2.1) multi_json (1.8.4) multi_test (0.0.3) - net-http-persistent (2.9.3) + net-http-persistent (2.9.4) page-object (0.9.6) page_navigation (>= 0.9) selenium-webdriver (>= 2.39.0) diff --git a/tests/browser/features/login_required_watchlist.feature b/tests/browser/features/login_required_watchlist.feature index 8fec6d2..75c2ef1 100644 --- a/tests/browser/features/login_required_watchlist.feature +++ b/tests/browser/features/login_required_watchlist.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org @user_agent +@custom-browser @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org Feature: Login required for Watchlist Scenario: Login for Uploads @@ -6,5 +6,3 @@ When I select Watchlist Then I receive watchlist message A watchlist helps you bookmark pages and keep track of changes to them And I receive watchlist message Log in to see it. - - diff --git a/tests/browser/features/random_ua.feature b/tests/browser/features/random_ua.feature index 4f822d1..abbc7e5 100644 --- a/tests/browser/features/random_ua.feature +++ b/tests/browser/features/random_ua.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org @user_agent +@custom-browser @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org Feature: Setting User Agents Scenario: Opera Mini diff --git a/tests/browser/features/support/hooks.rb b/tests/browser/features/support/hooks.rb index 784542e..d48f3ac 100644 --- a/tests/browser/features/support/hooks.rb +++ b/tests/browser/features/support/hooks.rb @@ -1,4 +1,3 @@ -Before("@user_agent") do |scenario| - @user_agent = true +Before("@custom-browser") do |scenario| @scenario = scenario -end \ No newline at end of file +end -- To view, visit https://gerrit.wikimedia.org/r/113776 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iae1e40e04c0b993a45c1e46cd971c183b483bc70 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
