Yuvipanda has uploaded a new change for review. https://gerrit.wikimedia.org/r/113803
Change subject: Display message when no saved pages exist ...................................................................... Display message when no saved pages exist Bug: 60708 Change-Id: Ib64bd23c84c7a840838472ac408a95143d7dbb1a --- M wikipedia/res/layout/activity_saved_pages.xml M wikipedia/res/values/strings.xml M wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java 3 files changed, 13 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/03/113803/1 diff --git a/wikipedia/res/layout/activity_saved_pages.xml b/wikipedia/res/layout/activity_saved_pages.xml index a639920..980abaa 100644 --- a/wikipedia/res/layout/activity_saved_pages.xml +++ b/wikipedia/res/layout/activity_saved_pages.xml @@ -1,13 +1,19 @@ <?xml version="1.0" encoding="utf-8"?> -<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"; - android:orientation="vertical" +<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"; android:layout_width="match_parent" android:layout_height="match_parent"> + <org.wikipedia.styledviews.StyledTextView + android:id="@+id/saved_pages_empty_message" + android:layout_width="match_parent" + android:layout_height="match_parent" + android:gravity="center" + android:text="@string/saved_pages_empty_message" + /> <ListView android:id="@+id/saved_pages_list" android:layout_width="match_parent" android:layout_height="match_parent" /> -</LinearLayout> \ No newline at end of file +</FrameLayout> \ No newline at end of file diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml index 1bfa8a6..26569ad 100644 --- a/wikipedia/res/values/strings.xml +++ b/wikipedia/res/values/strings.xml @@ -79,4 +79,5 @@ <string name="login_error_no_network">No network connection</string> <string name="nav_item_logout">Log out</string> <string name="logging_out_progress">Logging out...</string> + <string name="saved_pages_empty_message">No saved pages.</string> </resources> diff --git a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java index 1bb5598..2300c9f 100644 --- a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java +++ b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesActivity.java @@ -28,6 +28,7 @@ public class SavedPagesActivity extends ActionBarActivity implements LoaderManager.LoaderCallbacks<Cursor> { private ListView savedPagesList; + private View savedPagesEmpty; private SavedPagesAdapter adapter; private WikipediaApp app; @@ -41,9 +42,11 @@ setContentView(R.layout.activity_saved_pages); savedPagesList = (ListView) findViewById(R.id.saved_pages_list); + savedPagesEmpty = findViewById(R.id.saved_pages_empty_message); adapter = new SavedPagesAdapter(this, null, true); savedPagesList.setAdapter(adapter); + savedPagesList.setEmptyView(savedPagesEmpty); savedPagesList.setOnItemLongClickListener(new AdapterView.OnItemLongClickListener() { @Override -- To view, visit https://gerrit.wikimedia.org/r/113803 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib64bd23c84c7a840838472ac408a95143d7dbb1a Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Yuvipanda <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
