MarkTraceur has uploaded a new change for review.
https://gerrit.wikimedia.org/r/114188
Change subject: Get article path for foreign DB repos too
......................................................................
Get article path for foreign DB repos too
We have had this method in all Repo subclasses for a while, but sadly
it never got used and we've unintentionally crippled foreign DB repos
for some time now.
{{fixed}}
Change-Id: I972eb739cdd56c666981d5fbc371fa53024ff359
Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/217
---
M resources/mmv/ui/mmv.ui.metadataPanel.js
1 file changed, 9 insertions(+), 20 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/88/114188/1
diff --git a/resources/mmv/ui/mmv.ui.metadataPanel.js
b/resources/mmv/ui/mmv.ui.metadataPanel.js
index 7bf8ec3..dfcbd2e 100644
--- a/resources/mmv/ui/mmv.ui.metadataPanel.js
+++ b/resources/mmv/ui/mmv.ui.metadataPanel.js
@@ -372,28 +372,17 @@
* @param {string} gender
*/
MPP.setUserPageLink = function ( repoData, username, gender ) {
- var userlink,
- userpage = 'User:' + username;
+ var userpage = 'User:' + username,
+ articlePath = repoData.getArticlePath(),
+ userlink = articlePath.replace( '$1', userpage );
- if ( repoData instanceof mw.mmv.model.ForeignDbRepo ) {
- // We basically can't do anything about this; fail
- this.$username.addClass( 'empty' );
- } else {
- if ( repoData.absoluteArticlePath ) {
- userlink = repoData.absoluteArticlePath;
- } else {
- userlink = mw.config.get( 'wgArticlePath' );
- }
- userlink = userlink.replace( '$1', userpage );
+ this.$username
+ .text(
+ mw.message( 'multimediaviewer-userpage-link',
username, gender ).text()
+ )
+ .prop( 'href', userlink );
- this.$username
- .text(
- mw.message(
'multimediaviewer-userpage-link', username, gender ).text()
- )
- .prop( 'href', userlink );
-
- this.$usernameLi.toggleClass( 'empty', !username );
- }
+ this.$usernameLi.toggleClass( 'empty', !username );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/114188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I972eb739cdd56c666981d5fbc371fa53024ff359
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
