jenkins-bot has submitted this change and it was merged.
Change subject: Show placeholder text in group input box on reference list
dialog
......................................................................
Show placeholder text in group input box on reference list dialog
Set to "General references" for now.
Bug: 59180
Change-Id: I39c3692c71674ff656617500aa22ec7191db2e96
---
M VisualEditor.php
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/ui/dialogs/ve.ui.MWReferenceListDialog.js
4 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/VisualEditor.php b/VisualEditor.php
index b34cb26..90a3531 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -695,6 +695,7 @@
'visualeditor-dialog-reference-insert-button',
'visualeditor-dialog-reference-insert-title',
'visualeditor-dialog-reference-options-group-label',
+
'visualeditor-dialog-reference-options-group-placeholder',
'visualeditor-dialog-reference-options-name-label',
'visualeditor-dialog-reference-options-section',
'visualeditor-dialog-reference-title',
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 6c902f6..f52a048 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -86,6 +86,7 @@
"visualeditor-dialog-reference-insert-button": "Insert reference",
"visualeditor-dialog-reference-insert-title": "Insert reference",
"visualeditor-dialog-reference-options-group-label": "Use this group",
+ "visualeditor-dialog-reference-options-group-placeholder": "General
references",
"visualeditor-dialog-reference-options-name-label": "Re-use by this name",
"visualeditor-dialog-reference-options-section": "Options",
"visualeditor-dialog-reference-title": "Reference",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index ea6b5e9..6337a08 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -91,6 +91,7 @@
"visualeditor-dialog-reference-insert-button": "Used as label for the
button.\n{{Identical|Insert reference}}",
"visualeditor-dialog-reference-insert-title": "Reference insert dialog
title text.\n{{Identical|Insert reference}}",
"visualeditor-dialog-reference-options-group-label": "Label for the
reference group input",
+ "visualeditor-dialog-reference-options-group-placeholder": "Placeholder
for the reference group input",
"visualeditor-dialog-reference-options-name-label": "Label for the
reference name input",
"visualeditor-dialog-reference-options-section": "Label for the reference
options sub-section.\n{{Identical|Options}}",
"visualeditor-dialog-reference-title": "{{Identical|Reference}}",
@@ -206,4 +207,4 @@
"visualeditor-wikitext-warning": "Contents of notification displayed when
Wikitext has been detected.\n\nRefers to:\n*
{{msg-mw|Visualeditor-wikitext-warning-link}}\n*
{{msg-mw|Visualeditor-ca-editsource}}",
"visualeditor-wikitext-warning-link": "Link to page describing what
Wikitext is.\n\nUsed in:\n* {{msg-mw|Visualeditor-wikitext-warning}}.",
"visualeditor-wikitext-warning-title": "Title of notification displayed
when Wikitext has been detected"
-}
\ No newline at end of file
+}
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceListDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceListDialog.js
index 0850278..ac04be2 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceListDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceListDialog.js
@@ -52,7 +52,10 @@
'icon': 'settings'
} );
- this.groupInput = new OO.ui.TextInputWidget( { '$': this.$ } );
+ this.groupInput = new OO.ui.TextInputWidget( {
+ '$': this.$,
+ 'placeholder': ve.msg(
'visualeditor-dialog-reference-options-group-placeholder' )
+ } );
this.groupField = new OO.ui.FieldLayout( this.groupInput, {
'$': this.$,
'align': 'top',
--
To view, visit https://gerrit.wikimedia.org/r/113684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39c3692c71674ff656617500aa22ec7191db2e96
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
