Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/114510

Change subject: Anchor id for the table of comments was missing
......................................................................

Anchor id for the table of comments was missing

I guess something in the entityview widget JavaScript code and/or
the DOM it creates was changed without changing that line too.

Bug: 61668
Change-Id: I507c754e42b28470430c0ef76e38c44bc44c09e6
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/10/114510/1

diff --git a/repo/resources/wikibase.ui.entityViewInit.js 
b/repo/resources/wikibase.ui.entityViewInit.js
index 5133e09..7f2b9f0 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -108,8 +108,8 @@
                                value: wb.entity
                        } ).appendTo( $claimsParent );
 
-                       // add 'wb-claim' id to entity page's Claims heading:
-                       $( '.wb-claimlist' )
+                       // This is here to be sure there is never a duplicate id
+                       $( '.wb-claimgrouplistview' )
                                .prev( '.wb-section-heading' )
                                .first()
                                .attr( 'id', 'claims' );

-- 
To view, visit https://gerrit.wikimedia.org/r/114510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I507c754e42b28470430c0ef76e38c44bc44c09e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to