jenkins-bot has submitted this change and it was merged.
Change subject: Anchor id in the claims section used by the TOC was missing
......................................................................
Anchor id in the claims section used by the TOC was missing
I guess something in the entityview widget JavaScript code and/or
the DOM it creates was changed without changing the id in that
line too.
Bug: 61668
Change-Id: I507c754e42b28470430c0ef76e38c44bc44c09e6
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
WikidataJenkins: Verified
jenkins-bot: Verified
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index 5133e09..7f2b9f0 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -108,8 +108,8 @@
value: wb.entity
} ).appendTo( $claimsParent );
- // add 'wb-claim' id to entity page's Claims heading:
- $( '.wb-claimlist' )
+ // This is here to be sure there is never a duplicate id
+ $( '.wb-claimgrouplistview' )
.prev( '.wb-section-heading' )
.first()
.attr( 'id', 'claims' );
--
To view, visit https://gerrit.wikimedia.org/r/114510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I507c754e42b28470430c0ef76e38c44bc44c09e6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WikidataJenkins <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
