BBlack has submitted this change and it was merged.

Change subject: regularly compact memory on varnish caches
......................................................................


regularly compact memory on varnish caches

Without regular vm compaction, we eventually run into
both varnish health issues and XFS-related log spam
of them form:

XFS: possible memory allocation deadlock in kmem_alloc (mode:0x250)

Change-Id: I119b1b70496f8f9cae101b80247a3710fd529900
---
M manifests/role/cache.pp
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  BBlack: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/role/cache.pp b/manifests/role/cache.pp
index c1886ea..b5dbba2 100644
--- a/manifests/role/cache.pp
+++ b/manifests/role/cache.pp
@@ -511,6 +511,14 @@
             'labs' => ["vdb"],
         }
 
+        # This seems to prevent long term memory fragmentation issues that
+        #  result in XFS deadlock log spam + bad problems for varnish health
+        cron { varnish_vm_compact_cron:
+            command => "echo 1 >/proc/sys/vm/compact_memory",
+            user => root,
+            minute => "*";
+        }
+
         #class { "varnish::packages": version => "3.0.3plus~rc1-wm5" }
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/114766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I119b1b70496f8f9cae101b80247a3710fd529900
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to