Brion VIBBER has submitted this change and it was merged.
Change subject: Display errors inline in Login form as well
......................................................................
Display errors inline in Login form as well
Change-Id: I659024483932bed53c53d7dc7cbc9117fae4fbcd
---
M wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
b/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
index 5345167..eab0e91 100644
--- a/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/login/LoginActivity.java
@@ -146,10 +146,10 @@
private void handleError(String result) {
if (result.equals("WrongPass")) {
passwordText.requestFocus();
- Crouton.makeText(this, R.string.login_error_wrong_password,
Style.ALERT).show();
+
passwordText.setError(getString(R.string.login_error_wrong_password));
} else if (result.equals("NotExists")) {
usernameText.requestFocus();
- Crouton.makeText(this, R.string.login_error_wrong_username,
Style.ALERT).show();
+
usernameText.setError(getString(R.string.login_error_wrong_username));
} else if (result.equals("Blocked")) {
Crouton.makeText(this, R.string.login_error_blocked,
Style.ALERT).show();
} else if (result.equals("Throttled")) {
--
To view, visit https://gerrit.wikimedia.org/r/114732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I659024483932bed53c53d7dc7cbc9117fae4fbcd
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
