MaxSem has submitted this change and it was merged. Change subject: Maintenance for MobileFrontend. ......................................................................
Maintenance for MobileFrontend. * Remove superfluous newlines. * Remove unused method MobileContext::removeQueryStringParameter(). * Remove unused method SpecialMobileOptions::checkMobileToken(). * Remove commented out and unreachable code. * Remove unused local variables. * Update docs. * Replace deprecated method calls. * Remove unused globals. * Remove/add (un)needed commas and semi-colons in JavaScript. * Update code formatting and indentation. * Update superfluous local variable assignment. * Add FIXME for probably unused local variable. * Remove redundant units in CSS. * Add fallback font where missing. Change-Id: Ife3bdcba407ff0c75b4c86da21256f5c8633d30e --- M DeviceDetection.php M MobileContext.php M MobileFormatter.php M MobileFrontend.body.php M MobileFrontend.php M javascripts/application.js M javascripts/filepage.js M javascripts/mf-navigation.js M javascripts/settings.js M skins/SkinMobile.php M skins/SkinMobileBase.php M specials/SpecialMobileFeedback.php M specials/SpecialMobileOptions.php M stylesheets/banner.css M stylesheets/common.css M stylesheets/contact-us.css M stylesheets/footer.css M stylesheets/header.css M stylesheets/mf-navigation-legacy.css M stylesheets/mf-navigation.css M stylesheets/references.css M tests/DeviceDetectionTest.php M tests/MobileContextTest.php M tests/MobileFrontendTest.php M tests/js/fixtures.js 25 files changed, 151 insertions(+), 210 deletions(-) Approvals: MaxSem: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/24261 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife3bdcba407ff0c75b4c86da21256f5c8633d30e Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> Gerrit-Reviewer: Brion VIBBER <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: MaxSem <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
