jenkins-bot has submitted this change and it was merged.
Change subject: Remove another ss_active_users check from SiteStats::isSane
......................................................................
Remove another ss_active_users check from SiteStats::isSane
Also add a comment to method doc to make sure, nobody will add it again.
Follow-Up: Id8f1cb7035ae0058fb34a6c7bdf7bf9f6c740a69
Follow-Up: I268599be96106e1175fdf9750a2adc9468ebc93c
Change-Id: Ifd6da554b531720aace4497f7fbc2f58c12edc07
---
M includes/SiteStats.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/SiteStats.php b/includes/SiteStats.php
index 6e2b5fa..7169b2e 100644
--- a/includes/SiteStats.php
+++ b/includes/SiteStats.php
@@ -221,6 +221,8 @@
/**
* Is the provided row of site stats sane, or should it be regenerated?
*
+ * Checks only fields which are filled by SiteStatsInit::refresh.
+ *
* @param $row
*
* @return bool
@@ -229,7 +231,6 @@
if ( $row === false
|| $row->ss_total_pages < $row->ss_good_articles
|| $row->ss_total_edits < $row->ss_total_pages
- || $row->ss_users < $row->ss_active_users
) {
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/115198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd6da554b531720aace4497f7fbc2f58c12edc07
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Springle <[email protected]>
Gerrit-Reviewer: Tim Starling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
