[MediaWiki-commits] [Gerrit] Make the preview task POST - change (apps...wikipedia)

[Brion VIBBER (Code Review)]

Brion VIBBER has submitted this change and it was merged.

Change subject: Make the preview task POST
......................................................................


Make the preview task POST

Change-Id: Ic0ea37941823de6fba0de4bf5c2708c3c69961b5
---
M wikipedia-it/src/main/java/org/wikipedia/test/PreviewTaskTests.java
M wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
2 files changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git 
a/wikipedia-it/src/main/java/org/wikipedia/test/PreviewTaskTests.java 
b/wikipedia-it/src/main/java/org/wikipedia/test/PreviewTaskTests.java
index 9d3f342..ba87a37 100644
--- a/wikipedia-it/src/main/java/org/wikipedia/test/PreviewTaskTests.java
+++ b/wikipedia-it/src/main/java/org/wikipedia/test/PreviewTaskTests.java
@@ -3,7 +3,6 @@
 
 import android.content.*;
 import android.test.*;
-import android.util.*;
 import org.wikipedia.*;
 import org.wikipedia.editing.*;
 
@@ -19,8 +18,9 @@
     public void testPreview() throws Throwable {
         startActivity(new Intent(), null, null);
         final PageTitle title = new PageTitle(null, 
"Test_page_for_app_testing/Section1", new Site("test.wikipedia.org"));
-        final String wikitext = "== Section 2 ==\n\nEditing section INSERT 
RANDOM & HERE test at " + System.currentTimeMillis();
-        final String expected = "<div></div><h2><span class=\"mw-headline\" 
id=\"Section_2\">Section 2</span><a href=\"#editor/1\" data-section=\"1\" 
class=\"edit-page\">Edit</a></h2><div>\n<p>Editing section INSERT 
RANDOM</p>\n\n\n\n</div>";
+        long randomTime = System.currentTimeMillis();
+        final String wikitext = "== Section 2 ==\n\nEditing section INSERT 
RANDOM & HERE test at " + randomTime;
+        final String expected = "<div></div><h2><span class=\"mw-headline\" 
id=\"Section_2\">Section 2</span><a href=\"#editor/1\" data-section=\"1\" 
class=\"edit-page\">Edit</a></h2><div>\n<p>Editing section INSERT RANDOM &amp; 
HERE test at " + randomTime + "</p>\n\n\n\n</div>";
         final WikipediaApp app = 
(WikipediaApp)getInstrumentation().getTargetContext().getApplicationContext();
         final CountDownLatch completionLatch = new CountDownLatch(1);
         runTestOnUiThread(new Runnable() {
diff --git a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java 
b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
index 856e23f..dfb7a4f 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewTask.java
@@ -31,6 +31,11 @@
     }
 
     @Override
+    protected ApiResult makeRequest(RequestBuilder builder) {
+        return builder.post();
+    }
+
+    @Override
     public String processResult(ApiResult result) throws Throwable {
         return 
result.asObject().optJSONObject("parse").optJSONObject("text").optString("*");
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/115223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0ea37941823de6fba0de4bf5c2708c3c69961b5
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits