Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/115309

Change subject: Always try to put redirects at index 0, offset 0
......................................................................

Always try to put redirects at index 0, offset 0

This is a hack to make redirects work whilst Parsoid just dumbly inserts them 
in-
place, and should be removed once Parsoid handles that logic.

Bug: 61862
Change-Id: Ie3dc85ec29db3197f1a13744f7974f0bec5d427d
---
M modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/09/115309/1

diff --git a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
index de1e1ae..aab4c54 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
@@ -309,7 +309,8 @@
                } else {
                        if ( newRedirectData ) {
                                // There's no existing redirect but there is a 
new one, so create
-                               this.metaList.insertMeta( newRedirectItemData );
+                               // HACK: Putting this at index 0, offset 0 so 
that it works – bug 61862
+                               this.metaList.insertMeta( newRedirectItemData, 
0, 0 );
                        }
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/115309
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3dc85ec29db3197f1a13744f7974f0bec5d427d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.23wmf15
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to