Mooeypoo has uploaded a new change for review. https://gerrit.wikimedia.org/r/115338
Change subject: Add 'change' event to MediaSizeWidget ...................................................................... Add 'change' event to MediaSizeWidget Make sure other elements can respond to MediaSizeWidget's change event, fired on changing the current dimensions. Especially important for this commit: https://gerrit.wikimedia.org/r/#/c/114420/ Change-Id: Ie96fd7f64655a1ba89781e3a8106e580a4febebe --- M modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/38/115338/1 diff --git a/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js b/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js index 521da79..fe07778 100644 --- a/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js +++ b/modules/ve/ui/widgets/ve.ui.MediaSizeWidget.js @@ -110,6 +110,12 @@ OO.mixinClass( ve.ui.MediaSizeWidget, ve.Scalable ); +/* Events */ + +/** + * @event event + */ + /* Methods */ /** @@ -152,6 +158,8 @@ /** * Overridden from ve.Scalable to allow one dimension to be set * at a time, write values back to inputs and show any errors. + * + * @fires change */ ve.ui.MediaSizeWidget.prototype.setCurrentDimensions = function ( dimensions ) { // Recursion protection @@ -188,6 +196,8 @@ this.errorLabel.$element.toggle( !this.isCurrentDimensionsValid() ); this.$element.toggleClass( 've-ui-mediaSizeWidget-input-hasError', !this.isCurrentDimensionsValid() ); + // Emit change event + this.emit( 'change' ); this.preventChangeRecursion = false; }; -- To view, visit https://gerrit.wikimedia.org/r/115338 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie96fd7f64655a1ba89781e3a8106e580a4febebe Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Mooeypoo <mor...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
