jenkins-bot has submitted this change and it was merged.
Change subject: Simulate minor edit in _rtselser end point
......................................................................
Simulate minor edit in _rtselser end point
This appends a comment node to the body to force selser to drop into the body.
This exposes selser issues when serializing top-level content elements.
TODO:
- Do something like this in rt testing
- (maybe) do some more advanced edits
Bug: 56601
Change-Id: I8b1ef27b92e0be058aedfb93999c3aa7b48ddfbb
---
M api/ParsoidService.js
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/api/ParsoidService.js b/api/ParsoidService.js
index 31a14ff..85d2f0b 100644
--- a/api/ParsoidService.js
+++ b/api/ParsoidService.js
@@ -199,6 +199,8 @@
var i;
// XXX TODO FIXME BBQ There should be an error callback
in SelSer.
out = out.join('');
+ // Strip selser trigger comment
+ out = out.replace(/<!--rtSelserEditTestComment-->\n$/,
'');
if ( out === undefined ) {
console.log( 'Serializer error!' );
out = "An error occured in the
WikitextSerializer, please check the log for information";
@@ -511,7 +513,9 @@
}
var tpr = new TemplateRequest( env, target, oldid ),
tprCb = function ( req, res, src, document ) {
- var newDocument = DU.parseHTML(
DU.serializeNode(document) );
+ var newDocument = DU.parseHTML(
DU.serializeNode(document) ),
+ newNode =
newDocument.createComment('rtSelserEditTestComment');
+ newDocument.body.appendChild(newNode);
roundTripDiff( true, req, res, src, newDocument
);
};
--
To view, visit https://gerrit.wikimedia.org/r/115419
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b1ef27b92e0be058aedfb93999c3aa7b48ddfbb
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Marcoil <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
