EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/115529

Change subject: No need to call same function three times
......................................................................

No need to call same function three times

Change-Id: I56f28326d9905648094bd2ecbe3a3afd6ace152a
---
M includes/Repository/TreeRepository.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/29/115529/1

diff --git a/includes/Repository/TreeRepository.php 
b/includes/Repository/TreeRepository.php
index cd29a20..9bb47fa 100644
--- a/includes/Repository/TreeRepository.php
+++ b/includes/Repository/TreeRepository.php
@@ -228,8 +228,9 @@
                $roots = array();
 
                foreach( $descendants as $descendant ) {
-                       if ( isset( $paths[$descendant->getAlphadecimal()] ) ) {
-                               $roots[$descendant->getAlphadecimal()] = 
$paths[$descendant->getAlphadecimal()][0];
+                       $alpha = $descendant->getAlphadecimal();
+                       if ( isset( $paths[$alpha] ) ) {
+                               $roots[$alpha] = $paths[$alpha][0];
                        }
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/115529
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56f28326d9905648094bd2ecbe3a3afd6ace152a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to