jenkins-bot has submitted this change and it was merged.
Change subject: Change header message when saving in VE
......................................................................
Change header message when saving in VE
Change from "Previewing [page]" to "Saving [page]" since we're not
previewing anything. Update an existing unused message and use it (this
is probably temporary since VE edit summary will be in a flyout in
future).
Bug: 61050
Change-Id: Id8ef3672b5037f3da805ceb7c73d2506392f23d9
---
M MobileFrontend.i18n.php
M includes/Resources.php
M javascripts/modules/editor/EditorOverlayBase.js
M javascripts/modules/editor/VisualEditorOverlay.js
4 files changed, 11 insertions(+), 6 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MobileFrontend.i18n.php b/MobileFrontend.i18n.php
index a04a2a7..c2c9ec1 100644
--- a/MobileFrontend.i18n.php
+++ b/MobileFrontend.i18n.php
@@ -170,7 +170,7 @@
'mobile-frontend-meta-data-issues-header' => 'Issues',
'mobile-frontend-meta-data-issues' => 'This page has some issues',
- 'mobile-frontend-page-saving' => 'Saving $1',
+ 'mobile-frontend-page-saving' => '<strong>Saving</strong><span>
$1</span>',
'mobile-frontend-user-cta' => 'Please log in or sign up to see your
notifications.',
'mobile-frontend-user-button-tooltip' => 'Show my notifications',
@@ -727,11 +727,10 @@
{{Identical|History}}',
'mobile-frontend-meta-data-issues-header' => 'Heading for overlay
listing all cleanup templates',
'mobile-frontend-meta-data-issues' => 'This should be several words and
should explain that a page has cleanup templates on it - meaning there is room
for improvement on the page. It appears in a button that when clicked opens the
overlay with heading {{msg-mw|mobile-frontend-meta-data-issues-header}}',
- 'mobile-frontend-page-saving' => 'Unused at this time.
+ 'mobile-frontend-page-saving' => 'A heading saying what page will be
saved after editing. No part of the text should be outside <span> and
<strong> tags (<span> can contain text other than page title).
-Text shown whilst a page is being saved. Parameters:
-* $1 - page title
-{{Identical|Saving}}',
+Parameters:
+* $1 - page title',
'mobile-frontend-user-cta' => 'Appears when you click user icon when
not logged in. First link is to login form, 2nd to sign up form. Links are
created in JavaScript.',
'mobile-frontend-user-button-tooltip' => 'Title tooltip for the user
notifications button',
'mobile-frontend-nearby-to-page' => 'Header that describes that the
pages are related as they have locations near the location of the current page.
diff --git a/includes/Resources.php b/includes/Resources.php
index 8d2fc6f..879220d 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -346,6 +346,9 @@
'modules/editor/VisualEditorOverlayHeader',
'modules/editor/VisualEditorOverlay',
),
+ 'messages' => array(
+ 'mobile-frontend-page-saving',
+ ),
),
'mobile.editor.overlay' => $wgMFMobileResourceBoilerplate + array(
diff --git a/javascripts/modules/editor/EditorOverlayBase.js
b/javascripts/modules/editor/EditorOverlayBase.js
index e038559..825cd30 100644
--- a/javascripts/modules/editor/EditorOverlayBase.js
+++ b/javascripts/modules/editor/EditorOverlayBase.js
@@ -76,7 +76,9 @@
} else {
options.editingMsg = mw.msg(
'mobile-frontend-editor-editing-page', options.title );
}
- options.previewingMsg = mw.msg(
'mobile-frontend-editor-previewing-page', options.title );
+ if ( !options.previewingMsg ) {
+ options.previewingMsg = mw.msg(
'mobile-frontend-editor-previewing-page', options.title );
+ }
this.editCount = user.getEditCount();
this.isNewEditor = options.isNewEditor;
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index 1ecdbd8..bd292e9 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -11,6 +11,7 @@
className: 'overlay editor-overlay editor-overlay-ve',
initialize: function( options ) {
var self = this;
+ options.previewingMsg = mw.msg(
'mobile-frontend-page-saving', options.title );
this._super( options );
this.hasChanged = false;
this.$spinner = self.$( '.spinner' );
--
To view, visit https://gerrit.wikimedia.org/r/115550
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8ef3672b5037f3da805ceb7c73d2506392f23d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
