jenkins-bot has submitted this change and it was merged. Change subject: Clear registered events on unattach ......................................................................
Clear registered events on unattach Bug: 62033 Change-Id: Ic23a182ac2a74864831796ce493a0c51baa4fe8b Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/273 --- M resources/mmv/mmv.lightboxinterface.js 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Gilles: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mmv/mmv.lightboxinterface.js b/resources/mmv/mmv.lightboxinterface.js index cdffe07..09b62ad 100644 --- a/resources/mmv/mmv.lightboxinterface.js +++ b/resources/mmv/mmv.lightboxinterface.js @@ -238,6 +238,8 @@ } this.panel.fileReuse.closeDialog(); + + this.clearEvents(); }; /** @@ -303,6 +305,7 @@ $( document ).trigger( $.Event( 'mmv.hash', { hash : hashFragment } ) ); } + // FIXME makes no sense to do this on every image load this.handleEvent( 'keydown', function ( e ) { ui.keydown( e ); } ); // mousemove generates a ton of events, which is why we throttle it -- To view, visit https://gerrit.wikimedia.org/r/116047 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic23a182ac2a74864831796ce493a0c51baa4fe8b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
