Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/116072
Change subject: Add events for image views and "use this file" ...................................................................... Add events for image views and "use this file" Change-Id: I9ba37038e41d81bbb8dfa96b8a7766b35d24fa5a Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/54 --- M MultimediaViewer.php M resources/mmv/mmv.js M resources/mmv/mmv.logger.js M resources/mmv/ui/mmv.ui.fileReuse.js 4 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/72/116072/1 diff --git a/MultimediaViewer.php b/MultimediaViewer.php index f1b7212..cb4688a 100644 --- a/MultimediaViewer.php +++ b/MultimediaViewer.php @@ -500,7 +500,7 @@ $wgResourceModules['schema.MediaViewer'] = array( 'class' => 'ResourceLoaderSchemaModule', 'schema' => 'MediaViewer', - 'revision' => 6636420, + 'revision' => 7670440, ); $wgResourceModules['schema.MultimediaViewerNetworkPerformance'] = array( diff --git a/resources/mmv/mmv.js b/resources/mmv/mmv.js index 19532d7..03ca5b3 100755 --- a/resources/mmv/mmv.js +++ b/resources/mmv/mmv.js @@ -358,6 +358,8 @@ if ( this.blurredThumbnailShown && loadTime > 10 ) { this.lightbox.iface.canvas.unblur(); } + + mw.mmv.logger.log( 'image-view' ); }; /** diff --git a/resources/mmv/mmv.logger.js b/resources/mmv/mmv.logger.js index 060fc10..1b1bbc3 100644 --- a/resources/mmv/mmv.logger.js +++ b/resources/mmv/mmv.logger.js @@ -37,7 +37,9 @@ 'fullscreen-link-click': 'User clicked on fullscreen button in lightbox.', 'defullscreen-link-click': 'User clicked on button to return to normal lightbox view.', 'close-link-click': 'User clicked on the lightbox close button.', - 'site-link-click': 'User clicked on the link to the file description page.' + 'site-link-click': 'User clicked on the link to the file description page.', + 'use-this-file-link-click': 'User clicked on the link to use this file.', + 'image-view': 'User viewed an image' }; /** diff --git a/resources/mmv/ui/mmv.ui.fileReuse.js b/resources/mmv/ui/mmv.ui.fileReuse.js index dbc13de..ade1834 100644 --- a/resources/mmv/ui/mmv.ui.fileReuse.js +++ b/resources/mmv/ui/mmv.ui.fileReuse.js @@ -38,6 +38,7 @@ .prop( 'href', '#' ) .text( mw.message( 'multimediaviewer-use-file' ).text() ) .click( function () { + mw.mmv.logger.log( 'use-this-file-link-click' ); reuse.openDialog(); return false; } ) -- To view, visit https://gerrit.wikimedia.org/r/116072 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9ba37038e41d81bbb8dfa96b8a7766b35d24fa5a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
