Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116117

Change subject: Spam-checking moderation doesn't make sense
......................................................................

Spam-checking moderation doesn't make sense

Sending moderation stuff through AbuseFilter makes it slow
because there are filters matching against the post's content.
Said content will have to be run through Parsoid, which will
make it slow.
AFAIK, core moderation stuff doesn't go through AbuseFilter either.

I'd remove this, unless there's a very good reason to keep it.

Change-Id: I167acbb11423004cdeb37a5763d1a0ee6ea2f863
---
M includes/Block/Topic.php
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/17/116117/1

diff --git a/includes/Block/Topic.php b/includes/Block/Topic.php
index 593cc2a..d2fa451 100644
--- a/includes/Block/Topic.php
+++ b/includes/Block/Topic.php
@@ -287,9 +287,6 @@
                        $this->addError( 'moderate', wfMessage( 
'flow-error-not-allowed' ) );
                        return;
                }
-               if ( !$this->checkSpamFilters( $post, $this->newRevision ) ) {
-                       return;
-               }
        }
 
        protected function validateEditPost() {

-- 
To view, visit https://gerrit.wikimedia.org/r/116117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I167acbb11423004cdeb37a5763d1a0ee6ea2f863
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to