Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116173
Change subject: Let's just set a reasonable size in dp for the captcha image
......................................................................
Let's just set a reasonable size in dp for the captcha image
This lets the image scale up to expected size, and if we end up
with GIANT captcha images in future they don't fall offscreen
since they'll shrink instead.
Change-Id: Ie4a32fa57ab68b36e1061c43c8feddcc863a5908
---
M wikipedia/res/layout/group_captcha.xml
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/73/116173/1
diff --git a/wikipedia/res/layout/group_captcha.xml
b/wikipedia/res/layout/group_captcha.xml
index 629f1d9..12a29c6 100644
--- a/wikipedia/res/layout/group_captcha.xml
+++ b/wikipedia/res/layout/group_captcha.xml
@@ -14,21 +14,21 @@
style="?android:textAppearanceMedium"
android:layout_margin="16dp"
/>
- <FrameLayout android:layout_width="wrap_content"
android:layout_height="wrap_content">
+ <FrameLayout android:layout_width="fill_parent"
android:layout_height="wrap_content">
<ImageView
android:id="@+id/captcha_image"
android:layout_gravity="center_horizontal"
- android:layout_width="wrap_content"
- android:scaleType="centerInside"
- android:layout_height="wrap_content"
+ android:layout_width="240dp"
+ android:scaleType="fitCenter"
+ android:layout_height="80dp"
/>
<ProgressBar
android:id="@+id/captcha_image_progress"
android:indeterminate="true"
style="?android:progressBarStyleSmall"
android:visibility="gone"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"/>
+ android:layout_width="fill_parent"
+ android:layout_height="80dp"/>
</FrameLayout>
<org.wikipedia.styledviews.StyledTextView
android:layout_width="match_parent" android:layout_height="wrap_content"
android:text="@string/edit_section_captcha_reload"
--
To view, visit https://gerrit.wikimedia.org/r/116173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4a32fa57ab68b36e1061c43c8feddcc863a5908
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
