Yuvipanda has submitted this change and it was merged.
Change subject: Preserve activity & web view state across rotation etc
......................................................................
Preserve activity & web view state across rotation etc
We spent a bunch of trouble looking into ways to preserve the scroll
position and other state across orientation changes, with mediocre
results.
Turns out the Browser app simply ensures that it preserves the activity
across orientation and screen size changes -- the webView naturally
keeps the correct scroll position across an orientation change if we
just let it be instead of recreating everything.
Note we may still need to preserve scroll position explicitly across
an activity being killed or something, so haven't removed that existing
code using the basic scrollY position.
Bug: 61512
Change-Id: Iec3ae929d1bd8b0af2d94dcb9664827d659a235d
---
M wikipedia/AndroidManifest.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yuvipanda: Verified; Looks good to me, approved
diff --git a/wikipedia/AndroidManifest.xml b/wikipedia/AndroidManifest.xml
index a6175b5..6562582 100644
--- a/wikipedia/AndroidManifest.xml
+++ b/wikipedia/AndroidManifest.xml
@@ -20,6 +20,7 @@
<activity android:name=".page.PageActivity"
android:theme="@style/NoTitle"
android:windowSoftInputMode="stateHidden"
+
android:configChanges="orientation|keyboardHidden|keyboard|screenSize"
>
<intent-filter>
--
To view, visit https://gerrit.wikimedia.org/r/116867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec3ae929d1bd8b0af2d94dcb9664827d659a235d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
