Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117199
Change subject: labs_lvm: logoutput => on_failure for all exec calls
......................................................................
labs_lvm: logoutput => on_failure for all exec calls
Our puppet does not show the output of failed exec by default which make
the log TOTALLY UNHELPFUL.
Thus explicitly use: exec { logoutput => on_failure }
Change-Id: Icff8515153e4fb99a2c1514906f85b32ff4bec2a
---
M modules/labs_lvm/manifests/init.pp
M modules/labs_lvm/manifests/volume.pp
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/99/117199/1
diff --git a/modules/labs_lvm/manifests/init.pp
b/modules/labs_lvm/manifests/init.pp
index a9faffc..db5bd56 100644
--- a/modules/labs_lvm/manifests/init.pp
+++ b/modules/labs_lvm/manifests/init.pp
@@ -26,6 +26,7 @@
}
exec { 'create-volume-group':
+ logoutput => 'on_failure',
unless => '/sbin/vgdisplay -c vd',
require => File['/usr/local/sbin/make-instance-vg'],
command => "/usr/local/sbin/make-instance-vg '$disk'",
diff --git a/modules/labs_lvm/manifests/volume.pp
b/modules/labs_lvm/manifests/volume.pp
index 4217747..70873ef 100644
--- a/modules/labs_lvm/manifests/volume.pp
+++ b/modules/labs_lvm/manifests/volume.pp
@@ -44,6 +44,7 @@
exec { "create-vd-$volname":
unless => "/sbin/lvdisplay -c vd/$volname",
+ logoutput => 'on_failure',
require => [
File['/usr/local/sbin/make-instance-vol'],
Exec['create-volume-group']
--
To view, visit https://gerrit.wikimedia.org/r/117199
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icff8515153e4fb99a2c1514906f85b32ff4bec2a
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <has...@free.fr>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
