Niharika29 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/117394

Change subject: Don't show compact-link beta feature in list if it cannot be 
enabled
......................................................................

Don't show compact-link beta feature in list if it cannot
be enabled

Bug: 62362
Change-Id: Ib952cbd8e8733bdbca86a96fdde151f6651aa101
---
M UniversalLanguageSelector.hooks.php
1 file changed, 3 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector 
refs/changes/94/117394/1

diff --git a/UniversalLanguageSelector.hooks.php 
b/UniversalLanguageSelector.hooks.php
index f874785..a030a34 100644
--- a/UniversalLanguageSelector.hooks.php
+++ b/UniversalLanguageSelector.hooks.php
@@ -63,8 +63,7 @@
                $out->addModules( 'ext.uls.init' );
 
                // If compact ULS beta feature is enabled
-               if ( $wgULSCompactLinks &&
-                       $wgULSPosition === 'interlanguage' &&
+               if ( $wgULSPosition === 'interlanguage' &&
                        class_exists( 'BetaFeatures' ) &&
                        BetaFeatures::isFeatureEnabled( $out->getUser(), 
'uls-compact-links' )
                ) {
@@ -297,7 +296,6 @@
                        $vars['wgULSFontRepositoryBasePath'] = 
$wgExtensionAssetsPath .
                                
'/UniversalLanguageSelector/data/fontrepo/fonts/';
                }
-
                return true;
        }
 
@@ -337,8 +335,8 @@
        }
 
        public static function onGetBetaFeaturePreferences( $user, &$prefs ) {
-               global $wgExtensionAssetsPath, $wgULSCompactLinks;
-               if ( $wgULSCompactLinks ) {
+               global $wgExtensionAssetsPath, $wgULSCompactLinks, 
$wgULSPosition;
+               if ( $wgULSCompactLinks && $wgULSPosition === 'interlanguage') {
                        $prefs['uls-compact-links'] = array(
                                'label-message' => 'uls-betafeature-label',
                                'desc-message' => 'uls-betafeature-desc',

-- 
To view, visit https://gerrit.wikimedia.org/r/117394
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib952cbd8e8733bdbca86a96fdde151f6651aa101
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to