[MediaWiki-commits] [Gerrit] Don't use isset() to check whether an existing variable is null - change (mediawiki/core)

[IAlex (Code Review)]

IAlex has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/118092

Change subject: Don't use isset() to check whether an existing variable is null
......................................................................

Don't use isset() to check whether an existing variable is null

Change-Id: I05ad172f69189cbef86c65d5990e76edbedfd7c6
---
M includes/UserMailer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/118092/1

diff --git a/includes/UserMailer.php b/includes/UserMailer.php
index fe80929..4d8fce8 100644
--- a/includes/UserMailer.php
+++ b/includes/UserMailer.php
@@ -276,7 +276,7 @@
                                $headers = $mime->headers( $headers );
                        }
                }
-               if ( !isset( $mime ) ) {
+               if ( $mime === null ) {
                        // sending text only, either deliberately or as a 
fallback
                        if ( wfIsWindows() ) {
                                $body = str_replace( "\n", "\r\n", $body );

-- 
To view, visit https://gerrit.wikimedia.org/r/118092
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05ad172f69189cbef86c65d5990e76edbedfd7c6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <coderev...@emsenhuber.ch>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits