Brion VIBBER has submitted this change and it was merged.
Change subject: Use .equals not == for comparing strings
......................................................................
Use .equals not == for comparing strings
Change-Id: Ief36183409d91475eb052eae4dc18d1edfd8f54f
---
M wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git
a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
index b0f7013..08f2142 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
@@ -134,7 +134,7 @@
public void onCatch(Throwable caught) {
if (caught instanceof EditingException) {
EditingException ee = (EditingException) caught;
- if (app.getUserInfoStorage().isLoggedIn() &&
ee.getCode() == "badtoken") {
+ if (app.getUserInfoStorage().isLoggedIn() &&
ee.getCode().equals("badtoken")) {
// looks like our session expired.
app.getEditTokenStorage().clearAllTokens();
app.getCookieManager().clearAllCookies();
--
To view, visit https://gerrit.wikimedia.org/r/118054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief36183409d91475eb052eae4dc18d1edfd8f54f
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
