Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/118262
Change subject: Make entityselector work with deleted entities
......................................................................
Make entityselector work with deleted entities
Change-Id: I101d2c4706218384e3755cd8a61aaa6a0ee16a1c
---
M lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
1 file changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/62/118262/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
index ea9eb0d..d468631 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js
@@ -756,12 +756,11 @@
if ( result.error ) {
throw new Error( 'entity
selector: API returned error: '
+ result.error.info + '
(' + result.error.code + ')' );
- } else {
- if (
result.entities[entityId].labels !== undefined ) {
- // the entity has a
label in the language the entity selector has been
- // initialised with
- label =
result.entities[entityId].labels[self.options.language].value;
- }
+ } else if( result.entities[entityId] &&
+
result.entities[entityId].labels !== undefined ) {
+ // the entity exists and has a
label in the language the entity selector has been
+ // initialised with
+ label =
result.entities[entityId].labels[self.options.language].value;
}
setEntity( { id: entityId, label: label
} );
--
To view, visit https://gerrit.wikimedia.org/r/118262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I101d2c4706218384e3755cd8a61aaa6a0ee16a1c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
