Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/118281
Change subject: Fix global account deletion aborting early (w/o log entry)
......................................................................
Fix global account deletion aborting early (w/o log entry)
Follows up: Ie275b56
Change-Id: Ife2115318f00eb4cf9b672b62a4ca701871891a2
---
M CentralAuthUser.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth
refs/changes/81/118281/1
diff --git a/CentralAuthUser.php b/CentralAuthUser.php
index 4df9b92..6eb2a42 100644
--- a/CentralAuthUser.php
+++ b/CentralAuthUser.php
@@ -1052,12 +1052,12 @@
$centralDB->begin();
# Delete and lock the globaluser row
$centralDB->delete( 'globaluser', array( 'gu_name' =>
$this->mName ), __METHOD__ );
- # Delete all global user groups for the user
- $centralDB->delete( 'global_user_groups', array( 'gug_user' =>
$this->getId() ), __METHOD__ );
if ( !$centralDB->affectedRows() ) {
$centralDB->commit();
return Status::newFatal(
'centralauth-admin-delete-nonexistent', $this->mName );
}
+ # Delete all global user groups for the user
+ $centralDB->delete( 'global_user_groups', array( 'gug_user' =>
$this->getId() ), __METHOD__ );
# Delete the localuser rows
$centralDB->delete( 'localuser', array( 'lu_name' =>
$this->mName ), __METHOD__ );
$centralDB->commit();
--
To view, visit https://gerrit.wikimedia.org/r/118281
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife2115318f00eb4cf9b672b62a4ca701871891a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
