Cmcmahon has submitted this change and it was merged. Change subject: Moved "I am at a random page" step to the mediawiki_selenium Ruby gem ......................................................................
Moved "I am at a random page" step to the mediawiki_selenium Ruby gem Bug: 62479 Change-Id: I5184d191b99095ce34dc641bf9951887bc3c0d2f --- M tests/browser/features/hotcat.feature M tests/browser/features/pdf.feature M tests/browser/features/print_export_menu.feature M tests/browser/features/proveit.feature M tests/browser/features/sidebar.feature 5 files changed, 13 insertions(+), 14 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/hotcat.feature b/tests/browser/features/hotcat.feature index 611981b..11d087a 100644 --- a/tests/browser/features/hotcat.feature +++ b/tests/browser/features/hotcat.feature @@ -10,12 +10,11 @@ # https://git.wikimedia.org/blob/qa%2Fbrowsertests/HEAD/CREDITS # @login @test2.wikipedia.org - Feature: Hotcat Background: Given I am logged in - And I am at random page + And I am at a random page Scenario: Hotcat category link When I click the Categories link diff --git a/tests/browser/features/pdf.feature b/tests/browser/features/pdf.feature index 9950ea7..6e26d27 100644 --- a/tests/browser/features/pdf.feature +++ b/tests/browser/features/pdf.feature @@ -13,10 +13,10 @@ Feature: PDF Scenario: Check for Download as PDF link - Given I am at random page + Given I am at a random page Then Download as PDF should be present Scenario: Click on Download as PDF link - Given I am at random page + Given I am at a random page When I click on Download as PDF Then Download the file link should be present diff --git a/tests/browser/features/print_export_menu.feature b/tests/browser/features/print_export_menu.feature index a7e9277..97b5633 100644 --- a/tests/browser/features/print_export_menu.feature +++ b/tests/browser/features/print_export_menu.feature @@ -13,16 +13,16 @@ Feature: Print/Export menu Expand and Collapse Scenario: Check for Print/export section Expanded - Given I am at random page + Given I am at a random page Then Print/export section should be expanded Scenario: Check for Print/export section Collapsed - Given I am at random page + Given I am at a random page When I click Print/export Then Print/export section should be collapsed Scenario: Print/export section collapses after it is expanded - Given I am at random page + Given I am at a random page When I click Print/export And I click Print/export again Then Print/export section should be expanded diff --git a/tests/browser/features/proveit.feature b/tests/browser/features/proveit.feature index f307eb8..7113003 100644 --- a/tests/browser/features/proveit.feature +++ b/tests/browser/features/proveit.feature @@ -14,7 +14,7 @@ Background: Given I am logged in - When I am at random page + When I am at a random page And I click Edit button on the page And I click ProveIt show button And I click add a reference link diff --git a/tests/browser/features/sidebar.feature b/tests/browser/features/sidebar.feature index 7d7f88d..8266071 100644 --- a/tests/browser/features/sidebar.feature +++ b/tests/browser/features/sidebar.feature @@ -13,29 +13,29 @@ Feature: Sidebar Scenario: Go to a random page and interaction should be expanded - Given I am at random page + Given I am at a random page Then Interaction section should be expanded Scenario: Go to a random page and click interaction and it should collapse - Given I am at random page + Given I am at a random page When I click the interaction section Then Interaction section should be collapsed Scenario: Go to a random page and print/export section should be collapsed - Given I am at random page + Given I am at a random page Then Print export section should be collapsed Scenario: Go to a random page and click print/export and it should expand - Given I am at random page + Given I am at a random page When I click print export section Then Print export section should be expanded Scenario: Go to a random page and tools section should be collapsed - Given I am at random page + Given I am at a random page Then Tools section should be collapsed Scenario: Go to a random page and click tools and it should expand - Given I am at random page + Given I am at a random page When I click tools section Then Tools section should be expanded -- To view, visit https://gerrit.wikimedia.org/r/117862 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5184d191b99095ce34dc641bf9951887bc3c0d2f Gerrit-PatchSet: 3 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: Manybubbles <never...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
