Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/118695
Change subject: Initialize rank selector on the right element
......................................................................
Initialize rank selector on the right element
The commit 153f8a247e0ccf0c4e0044f8839623e659caee65 made the backend and the
frontend templating system emiting different HTML for the rank selector in a
statement view.
Change-Id: I059a3a0803f8bac60d97bbc8e57c18d7442c2bcb
---
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/95/118695/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index ed45f86..02f53e4 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -25,7 +25,7 @@
template: 'wb-statement',
templateParams: [
'wb-last', // class: wb-first|wb-last
- '', // Rank selector
+ '<div></div>', // Rank selector
function() { // class='wb-claim-$2'
return ( this._claim && this._claim.getGuid() )
|| 'new';
},
@@ -168,10 +168,11 @@
* @param {number} rank
*/
_createRankSelector: function( rank ) {
+ var $rankSelector = this.$rankSelector.children().first();
this._rankSelector = new $.wikibase.statementview.RankSelector(
{
rank: rank,
templateParams: ['ui-state-disabled', '', '']
- }, this.$rankSelector );
+ }, $rankSelector );
var self = this,
changeEvent = 'afterchange.' + this.widgetName;
--
To view, visit https://gerrit.wikimedia.org/r/118695
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I059a3a0803f8bac60d97bbc8e57c18d7442c2bcb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
