jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Kill RandomPage in favour of ArticlePage
......................................................................
Hygiene: Kill RandomPage in favour of ArticlePage
Change-Id: If9782d509d7e9c5d656682567cd9a6460b7f7156
---
M tests/browser/features/no_javascript_site.feature
M tests/browser/features/pageactions.feature
M tests/browser/features/step_definitions/common_steps.rb
D tests/browser/features/support/pages/random_page.rb
4 files changed, 4 insertions(+), 17 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/no_javascript_site.feature
b/tests/browser/features/no_javascript_site.feature
index 1bc60e2..3563c04 100644
--- a/tests/browser/features/no_javascript_site.feature
+++ b/tests/browser/features/no_javascript_site.feature
@@ -4,7 +4,7 @@
# FIXME: Add scenario to check watch star actually works
Scenario: Able to search in basic non-JavaScript site
Given I am using user agent "Opera/9.80 (J2ME/MIDP; Opera Mini/9.80 (S60;
SymbOS; Opera Mobi/23.348; U; en) Presto/2.5.25 Version/10.54"
- When I go to random page
+ When I click on "Random" in the main navigation menu
Then I see the watch star
And I see the search button
# FIXME: Check that the edit button is invisible
@@ -12,7 +12,7 @@
Scenario: Able to access left navigation in basic non-JavaScript site
Given I am using user agent "Opera/9.80 (J2ME/MIDP; Opera Mini/9.80 (S60;
SymbOS; Opera Mobi/23.348; U; en) Presto/2.5.25 Version/10.54"
- When I go to random page
+ When I click on "Random" in the main navigation menu
And I click on the main navigation button
Then I see a link to "Home" in the main navigation menu
And I see a link to "Random" in the main navigation menu
diff --git a/tests/browser/features/pageactions.feature
b/tests/browser/features/pageactions.feature
index 03f2577..503d496 100644
--- a/tests/browser/features/pageactions.feature
+++ b/tests/browser/features/pageactions.feature
@@ -2,7 +2,8 @@
Feature: Page actions menu when anonymous
Background:
- Given I go to random page
+ Given I am on the "Main Page" page
+ And I click on "Random" in the main navigation menu
Scenario: Receive notification message - Edit Icon
When I click the edit icon holder
diff --git a/tests/browser/features/step_definitions/common_steps.rb
b/tests/browser/features/step_definitions/common_steps.rb
index 900f824..4e3c029 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -89,10 +89,6 @@
# nothing to do here, user in not logged in by default
end
-When /^I go to random page$/ do
- visit(RandomPage)
-end
-
Given(/^I am on the "(.+)" page$/) do |article|
visit(ArticlePage, :using_params => {:article_name => article})
end
diff --git a/tests/browser/features/support/pages/random_page.rb
b/tests/browser/features/support/pages/random_page.rb
deleted file mode 100644
index 08e2289..0000000
--- a/tests/browser/features/support/pages/random_page.rb
+++ /dev/null
@@ -1,10 +0,0 @@
-# FIXME: separate this into ArticlePage and LoginPage
-class RandomPage < ArticlePage
- include PageObject
-
- include URL
- page_url URL.url("Special:Random")
-
- div(:login_text, class: "headmsg")
- div(:login_text_wl, id: "content")
-end
--
To view, visit https://gerrit.wikimedia.org/r/117371
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9782d509d7e9c5d656682567cd9a6460b7f7156
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
