jenkins-bot has submitted this change and it was merged.
Change subject: Merge two Properties blocks in DesktopContext
......................................................................
Merge two Properties blocks in DesktopContext
Change-Id: I209e20c0ccd660218d3c65d716d35fb80ab84de9
---
M modules/ve/ui/ve.ui.DesktopContext.js
1 file changed, 5 insertions(+), 7 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ui/ve.ui.DesktopContext.js
b/modules/ve/ui/ve.ui.DesktopContext.js
index 43831b9..3966e4d 100644
--- a/modules/ve/ui/ve.ui.DesktopContext.js
+++ b/modules/ve/ui/ve.ui.DesktopContext.js
@@ -32,6 +32,11 @@
this.selection = null;
this.toolbar = null;
this.afterModelSelectTimeout = null;
+ this.$menu = this.$( '<div>' );
+ this.popup = new OO.ui.PopupWidget( {
+ '$': this.$,
+ '$container': this.surface.getView().$element
+ } );
// Events
this.surface.getModel().connect( this, { 'select': 'onModelSelect' } );
@@ -54,13 +59,6 @@
} );
this.$element.add( this.$menu )
.on( 'mousedown', false );
-
- // Properties
- this.$menu = this.$( '<div>' );
- this.popup = new OO.ui.PopupWidget( {
- '$': this.$,
- '$container': this.surface.getView().$element
- } );
// Initialization
this.$element.addClass( 've-ui-desktopContext' ).append(
this.popup.$element );
--
To view, visit https://gerrit.wikimedia.org/r/118766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I209e20c0ccd660218d3c65d716d35fb80ab84de9
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
