Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/118789
Change subject: Update VE core submodule to a3cb576
......................................................................
Update VE core submodule to a3cb576
Also update ContentBranchNode test for changes in VE core
New changes:
a3cb576 Make ContentBranchNode echo suppression work in CBNs that contain
inline nodes
Change-Id: I3e1757b42307c3bd52ba0571068eb1c6bfb5ab89
---
M lib/ve
M modules/ve-mw/test/ce/ve.ce.ContentBranchNode.test.js
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/89/118789/1
diff --git a/lib/ve b/lib/ve
index cd00a93..a3cb576 160000
--- a/lib/ve
+++ b/lib/ve
-Subproject commit cd00a93d2f69218ec4796d47205da884b17779cd
+Subproject commit a3cb5762a808896fab940a5f1bacd14cd43cf73e
diff --git a/modules/ve-mw/test/ce/ve.ce.ContentBranchNode.test.js
b/modules/ve-mw/test/ce/ve.ce.ContentBranchNode.test.js
index 22ba858..877119b 100644
--- a/modules/ve-mw/test/ce/ve.ce.ContentBranchNode.test.js
+++ b/modules/ve-mw/test/ce/ve.ce.ContentBranchNode.test.js
@@ -44,8 +44,7 @@
QUnit.expect( cases.length );
for ( i = 0, len = cases.length; i < len; i++ ) {
doc = new ve.dm.Document( ve.dm.example.preprocessAnnotations(
cases[i].data ) );
- $rendered = ( new ve.ce.ParagraphNode(
doc.getDocumentNode().getChildren()[0] ) ).getRenderedContents();
- $wrapper = $( '<div>' ).append( $rendered );
+ $wrapper = $( new ve.ce.ParagraphNode(
doc.getDocumentNode().getChildren()[0] ).getRenderedContents() );
// HACK strip out all the class="ve-ce-TextStyleAnnotation
ve-ce-TextStyleBoldAnnotation" crap
$wrapper.find( '.ve-ce-TextStyleAnnotation' ).removeAttr(
'class' );
assert.equalDomElement( $wrapper[0], $( '<div>' ).html(
cases[i].html )[0], cases[i].msg );
--
To view, visit https://gerrit.wikimedia.org/r/118789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e1757b42307c3bd52ba0571068eb1c6bfb5ab89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
