jenkins-bot has submitted this change and it was merged. Change subject: Mention possibility of $revision being null in PageContentSaveComplete ......................................................................
Mention possibility of $revision being null in PageContentSaveComplete Lead to a fatal in WMF production, see I40c1412d Change-Id: I39e05210e77f3dc0a1fcd995201a9c1ec9bc99f3 --- M docs/hooks.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified diff --git a/docs/hooks.txt b/docs/hooks.txt index a833484..e944d55 100644 --- a/docs/hooks.txt +++ b/docs/hooks.txt @@ -1824,7 +1824,7 @@ $isWatch: (No longer used) $section: (No longer used) $flags: Flags passed to WikiPage::doEditContent() -$revision: New Revision of the article +$revision: New Revision of the article (can be null for edits that change nothing) $status: Status object about to be returned by doEditContent() $baseRevId: the rev ID (or false) this edit was based on -- To view, visit https://gerrit.wikimedia.org/r/117625 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39e05210e77f3dc0a1fcd995201a9c1ec9bc99f3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Alex Monk <[email protected]> Gerrit-Reviewer: IAlex <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Waldir <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
