jenkins-bot has submitted this change and it was merged.
Change subject: Micro-optimization for MessageGroups::haveSingleSourceLanguage
......................................................................
Micro-optimization for MessageGroups::haveSingleSourceLanguage
The new algorithm scales linearly
Change-Id: I36f0432fd83e80ae60101bf90a5fcc01d693e714
---
M MessageGroups.php
1 file changed, 6 insertions(+), 8 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
Nemo bis: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/MessageGroups.php b/MessageGroups.php
index da5db47..f4ad796 100644
--- a/MessageGroups.php
+++ b/MessageGroups.php
@@ -636,20 +636,18 @@
* @since 2013.09
*/
public static function haveSingleSourceLanguage( array $groups ) {
- $languages = array();
+ $seen = '';
foreach ( $groups as $group ) {
$language = $group->getSourceLanguage();
- if ( !in_array( $language, $languages ) ) {
- $languages[] = $language;
+ if ( $seen === '' ) {
+ $seen = $language;
+ } elseif ( $language !== $seen ) {
+ return '';
}
}
- if ( count( $languages ) === 1 ) {
- return $languages[0];
- }
-
- return '';
+ return $seen;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/118814
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36f0432fd83e80ae60101bf90a5fcc01d693e714
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
