Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119481
Change subject: Fall back to "... in [en]" if language name isn't available
......................................................................
Fall back to "... in [en]" if language name isn't available
The placeholders use two messages, one being language aware and one
not. The tooltips behind the [?] icons do not. A possible solution
would be to do the same and use two messages.
But:
1. Completely removing the information could be confusing,
escpecially if you have a Babel box and are prompted for
multiple languages.
2. I don't want to introduce new messages at the moment since we
are going to redesign the whole thing anyway.
3. It's not really relevant since this only happens in environments
where ULS is not available (e.g. some of our own test
environments).
Simply falling back to '[en]' instead of 'English' is a decent
workaround, in my opinion. It's the same format as in the watchlist
and log summary lines so users should recognize it.
Change-Id: I32a893bed54454ef4b0a947a85d0b78f06d5aa95
---
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/81/119481/1
diff --git a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
index fd153d0..fab55b4 100644
--- a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
+++ b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
@@ -831,9 +831,11 @@
* @return string
*/
getInputHelpMessage: function() {
- var langName = wb.getLanguageNameByCode(
this.getValueLanguageContext() );
+ var langCode = this.getValueLanguageContext(),
+ langName = wb.getLanguageNameByCode( langCode );
+ // TODO: Currently shows the code (which is better than
nothing) if ULS is not available
return this._options.inputHelpMessageKey
- ? mw.msg( this._options.inputHelpMessageKey, langName )
+ ? mw.msg( this._options.inputHelpMessageKey, langName
|| '[' + langCode + ']' )
: '';
},
--
To view, visit https://gerrit.wikimedia.org/r/119481
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I32a893bed54454ef4b0a947a85d0b78f06d5aa95
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
