Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/119491

Change subject: Add disabled styling to InlineMenuWidget
......................................................................

Add disabled styling to InlineMenuWidget

The menu as a whole can be diabled, or specific options. Add
greyed-out styling to apex, and cursor:default to core styles.

Change-Id: I0d1c8cf5b8c1d98e24b7c23109f802da4850a559
---
M demos/widgets.js
M src/styles/widgets/InlineMenuWidget.less
M src/themes/apex/widgets/InlineMenuWidget.less
M src/themes/apex/widgets/OptionWidget.less
4 files changed, 67 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/91/119491/1

diff --git a/demos/widgets.js b/demos/widgets.js
index b76d04e..4e91e70 100644
--- a/demos/widgets.js
+++ b/demos/widgets.js
@@ -280,6 +280,53 @@
                                                }
                                        } ),
                                        { 'label': 'InlineMenuWidget' }
+                               ),
+                               new OO.ui.FieldLayout(
+                                       new OO.ui.InlineMenuWidget( {
+                                               'label': 'Select one',
+                                               'menu': {
+                                                       'items': [
+                                                               new 
OO.ui.MenuItemWidget( 'a',  {
+                                                                       
'label': 'First'
+                                                               } ),
+                                                               new 
OO.ui.MenuItemWidget( 'b', {
+                                                                       
'label': 'Disabled',
+                                                                       
'disabled': true
+                                                               } ),
+                                                               new 
OO.ui.MenuItemWidget( 'c', {
+                                                                       
'label': 'Third'
+                                                               } ),
+                                                               new 
OO.ui.MenuItemWidget( 'd', {
+                                                                       
'label': 'Disabled',
+                                                                       
'disabled': true
+                                                               } )
+                                                       ]
+                                               }
+                                       } ),
+                                       { 'label': 'InlineMenuWidget (options 
disabled)' }
+                               ),
+                               new OO.ui.FieldLayout(
+                                       new OO.ui.InlineMenuWidget( {
+                                               'label': 'Select one',
+                                               'disabled': true,
+                                               'menu': {
+                                                       'items': [
+                                                               new 
OO.ui.MenuItemWidget( 'a',  {
+                                                                       
'label': 'First'
+                                                               } ),
+                                                               new 
OO.ui.MenuItemWidget( 'b', {
+                                                                       
'label': 'Second'
+                                                               } ),
+                                                               new 
OO.ui.MenuItemWidget( 'c', {
+                                                                       
'label': 'Third'
+                                                               } ),
+                                                               new 
OO.ui.MenuItemWidget( 'd', {
+                                                                       
'label': 'Fourth'
+                                                               } )
+                                                       ]
+                                               }
+                                       } ),
+                                       { 'label': 'InlineMenuWidget 
(disabled)' }
                                )
                        ]
                };
diff --git a/src/styles/widgets/InlineMenuWidget.less 
b/src/styles/widgets/InlineMenuWidget.less
index dbfddba..82b79ec 100644
--- a/src/styles/widgets/InlineMenuWidget.less
+++ b/src/styles/widgets/InlineMenuWidget.less
@@ -50,4 +50,8 @@
        .oo-ui-menuWidget {
                width: 100%;
        }
+
+       &.oo-ui-widget-disabled .oo-ui-inlineMenuWidget-handle {
+               cursor: default;
+       }
 }
diff --git a/src/themes/apex/widgets/InlineMenuWidget.less 
b/src/themes/apex/widgets/InlineMenuWidget.less
index 1a9e7ab..940da3a 100644
--- a/src/themes/apex/widgets/InlineMenuWidget.less
+++ b/src/themes/apex/widgets/InlineMenuWidget.less
@@ -14,4 +14,16 @@
                        opacity: 0.8;
                }
        }
+
+       &.oo-ui-widget-disabled {
+               .oo-ui-inlineMenuWidget-handle {
+                       color: #ccc;
+                       text-shadow: 0 1px 1px #fff;
+                       border-color: #ddd;
+                       background-color: #f3f3f3;
+               }
+               .oo-ui-indicatedElement-indicator {
+                       opacity: 0.5;
+               }
+       }
 }
diff --git a/src/themes/apex/widgets/OptionWidget.less 
b/src/themes/apex/widgets/OptionWidget.less
index e98d564..76bad4f 100644
--- a/src/themes/apex/widgets/OptionWidget.less
+++ b/src/themes/apex/widgets/OptionWidget.less
@@ -6,4 +6,8 @@
        &-selected {
                background-color: #a7dcff;
        }
+
+       &.oo-ui-widget-disabled {
+               color: #ccc;
+       }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/119491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d1c8cf5b8c1d98e24b7c23109f802da4850a559
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to