Cmcmahon has submitted this change and it was merged.
Change subject: Replace fragile checks with checks for spinner on save
......................................................................
Replace fragile checks with checks for spinner on save
Change-Id: If03cd180a1d1c22460ce34f944b317e624ac960e
---
M tests/browser/features/step_definitions/flow_steps.rb
1 file changed, 2 insertions(+), 11 deletions(-)
Approvals:
Cmcmahon: Verified; Looks good to me, approved
diff --git a/tests/browser/features/step_definitions/flow_steps.rb
b/tests/browser/features/step_definitions/flow_steps.rb
index 145fa1c..a2682ea 100644
--- a/tests/browser/features/step_definitions/flow_steps.rb
+++ b/tests/browser/features/step_definitions/flow_steps.rb
@@ -73,17 +73,8 @@
Then(/^the Flow page should contain (.+)$/) do |flow_topic|
on(FlowPage) do |page|
- page.wait_until(20) do # 10 seconds wasn't enough on ee-flow...
- # TODO Also match the regexp '[2-9] seconds ago' in case of delays.
- # TODO This should look in the particular topic that was added, not
- # blindly look for text.
- # It could note the ID of the first div with id 'flow-topic-<UUID>'
- # before submitting the new topic post,
- # then afterwards find the flow-topic-<UUID> div *preceding* that and
search in there.
- # Or after submit it could look for the Title of Flow Topic, find the
- # flow-topic-container containing that and search in there.
- page.text.include? "1 second ago" or page.text.include? "just now"
- end
+ page.small_spinner_element.when_present
+ page.small_spinner_element.when_not_present(20)
page.flow_body.should match(flow_topic + @random_string +
@automated_test_marker)
end
end
--
To view, visit https://gerrit.wikimedia.org/r/115659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If03cd180a1d1c22460ce34f944b317e624ac960e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
